Source selection is not filtering when ) is in source name

[jrusz]

The source selection in image creation wizard is not filtering the items properly if the source name has a ) in the name, see screenshots.

[ezr-ondrej]

Ok, found the issue, it is in PF4 itself.

https://github.com/patternfly/patternfly-react/blob/63b1d08cf7c4f02d32d5473db74f6f7ac0af88af/packages/react-core/src/components/Select/Select.tsx#L461

When the input value is a valid regex, it's treated as a regex, so I guess in case with My (source) we would need to escape the input as My \(source\) ... workaround would be to implement the filter ourselves.

It would not be easy to get a fix in patternfly given they do not support this version anymore.

[lavocatt]

Is it a bug in patternfly or a valid behavior ? Just by a the look of it it could be both IMO, the code tries to check if the text is a valid regex pattern and to use it that way and if not to escape all regex special characters.

The question is, do we want to let the user use regexs in the UI or not ?
If not, we could simply escape the string before it goes to patternfly ?

[lavocatt]

I think also that it's kinda neat to have the ability to filter on using a regex :)

[ezr-ondrej]

We would need to implement the search ourselves completely, there is no hook into the default implementation, either we reimplement, or we use default :)

I think it's a feature, but should be documented 😛