Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search through library should use backend side implementation #124

Open
2 of 9 tasks
orontee opened this issue Jan 22, 2023 · 2 comments
Open
2 of 9 tasks

Search through library should use backend side implementation #124

orontee opened this issue Jan 22, 2023 · 2 comments
Labels
design enhancement New feature or request ui

Comments

@orontee
Copy link
Owner

orontee commented Jan 22, 2023

With current implementation, search happens locally in the currently visited directory.

See https://docs.mopidy.com/en/latest/api/core/#mopidy.core.LibraryController.search

  • Add a model class for artists
    Since search results may contain albums, artists or tracks.
  • Add a library search action and extend model with search results
  • The search should be performed in a task and must be cancelable
  • UI to display search results
  • Setting to customize search query

UI draft

Displayed when entering search mode (by clicking search button or corresponding shortcut).
Page made of stack widget with:

  • A page made of a single centered label for "no result to display so far".
  • A page made of a progress bar for "ongoing search" (with a cancel button?)
  • A page for results with three sections albums, artists and tracks
  • Clicking on an album should enter the corresponding library view
  • Clicking on a track should enqueue/play (?) that track
  • Clicking on an artist should enter an artist view
  • Access to all album or tracks results

Questions left opened / Remarks

The interest of using the backend side search implementation is very limited when using Mopidy-Local, see
mopidy/mopidy-local#16.

How-to search locally in currently visited directory?

How-to disable some Mopidy backends? Should we care?

How-to choose search criteria? Should we care?

@orontee orontee added the enhancement New feature or request label Jan 22, 2023
@orontee orontee added this to the Spring 2023 release milestone Jan 22, 2023
@orontee orontee removed this from the Spring 2023 release milestone Jan 29, 2023
@orontee orontee added the design label Jan 30, 2023
orontee added a commit that referenced this issue Mar 12, 2023
orontee added a commit that referenced this issue May 1, 2023
orontee added a commit that referenced this issue May 1, 2023
orontee added a commit that referenced this issue May 1, 2023
@orontee orontee pinned this issue May 1, 2023
@orontee orontee added this to the Spring 2023 release milestone May 1, 2023
orontee added a commit that referenced this issue May 3, 2023
orontee added a commit that referenced this issue May 3, 2023
orontee added a commit that referenced this issue May 3, 2023
@orontee
Copy link
Owner Author

orontee commented May 3, 2023

Current UI state
image

@orontee orontee removed this from the Spring 2023 release milestone May 11, 2023
@orontee
Copy link
Owner Author

orontee commented May 11, 2023

Try to improve Mopidy-Local first...

orontee added a commit that referenced this issue Jun 8, 2023
orontee added a commit that referenced this issue Jun 8, 2023
@orontee orontee added the ui label May 23, 2024
@orontee orontee unpinned this issue May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement New feature or request ui
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant