-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add initial change set docs #3185
add initial change set docs #3185
Conversation
|
This comment was marked as outdated.
This comment was marked as outdated.
@samuelstroschein I struggle to understand the chart. Why are there two flows that I want to connect? Can you make an example? I saw it more like that: |
I know we already talked about, that an entity can be in multiple change sets, right? That would also be a big difference to commits and should be in the document. I would love to see a pro and cons of that approach and a reason why our path is the right one. That will also help the team and devs in the future understand why our system is built like this. |
Is a change set the only way I can add a discussion/context to a change? Are changes also able to link to a discussion? |
@NilsJacobsen which changes are put into a set is up to the user. the diagram uses two graphs to illustrate that grouping entities is possible. Entity example with a csv Every row is an entity. If you make a change to the inventory of all your products (all rows), you likely want to group the changes "updating inventory after closing store on 2022-09-03". Entity example with inlang Translating multiple german variants are updates to multiply entities (every variant is it's own entity). If you confirm the changes, you likely want to group all distinct entity updates e.g. variant1, variant2, variant3 in one set "created german translations"
Yes, because a discussion points to N changes. A set can have only one change. Action items
|
Ahh I see, I was confused by the entity visualization. Because it looks like separate timelines :D |
I am in favor of the change group for the same reasons you mentioned as pros |
I do not thinK that we should quickly jump to naming conclusions here. At least not for me as its really crucial people get this primitive. I seeked help from GPT to analyse the meaning & usage of both words in detail. For example, in maths (given the engineering context) a set and a group are two different things and they belong to different branches and serve distinct purposes. Here’s a breakdown of their differences: 1. Set (from Set Theory)
2. Group (from Group Theory)
Summary of Differences:
Outside of mathematics,the terms set and group can also have different meanings and uses in various fields. Here’s how they differ in common, non-mathematical contexts: 1. Set (General Usage)
2. Group (General Usage)
Key Differences Outside of Math:
Contextual Differences:
In summary, while both sets and groups involve collections, sets are generally about distinct items with no required interaction, while groups often involve people or things working together or sharing a common goal. Given this information, do we still thing "change group" applies better than "change set"? |
I already concluded that the name change set will remain because it's technically accurate. Thanks for chipping in. |
Context
Adds initial (!) change set documentation. The docs can be improved later on (!)
Requested feedback
If you have feedback that needs to be addressed before implementing change sets, raise it now. Re question 3 vote in a comment below.
Naming it change set or change group?Will leave it as sets add initial change set docs #3185 (comment)https://www.loom.com/share/8f950946d6b74e739c7b534d63a1a351?sid=eb3099c6-0564-4ee6-bdc5-79f5e6d38218