Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move toNotify Field to STORE_ONLY_IN_ARCHIVES Action in Card Actions #7447

Open
freddidierRTE opened this issue Oct 24, 2024 · 0 comments
Open
Labels
Enhancement New feature

Comments

@freddidierRTE
Copy link
Contributor

freddidierRTE commented Oct 24, 2024

Today, we have a field toNotify in the card.

The default value is true. When it is set to false, the card is only stored in the archives, so there is no notification on the feed.

The issue is to move this option to an action, i.e., a new possible action in the actions field of the card.

The name of this new action is STORE_ONLY_IN_ARCHIVES.

If the card is an update of an existing card that is in the feed:

  • It should first delete the existing card.
  • If the action is combined with KEEP_EXISTING_PUBLISH_DATE, it should keep the existing publish date for the new card.
  • If the action is combined with PROPAGATE_READ_ACK_TO_PARENT_CARD or KEEP_EXISTING_ACKS_AND_READS, these two actions shall be ignored.
  • If the action is combined with KEEP_CHILD_CARDS, it should behave in the archives as if we updated the existing card, keeping the child cards and then deleting the update.

The old field should be kept for backward compatibility but should be stated as deprecated in the documentation, and a log should be put in the cards-publication service with a warning if the field is used.

Add a Karate test similar to src/test/api/karate/cards/postCardWithToNotify.feature.

Update documentation

Add in migration guide

@freddidierRTE freddidierRTE added the Enhancement New feature label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature
Projects
Status: Ready
Development

No branches or pull requests

1 participant