Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporter can't provide feedback on success #186

Open
jcchavezs opened this issue Oct 24, 2020 · 3 comments
Open

Reporter can't provide feedback on success #186

jcchavezs opened this issue Oct 24, 2020 · 3 comments

Comments

@jcchavezs
Copy link
Contributor

Currently reporter is not providing any feedback about the call to the zipkin server, if it fails it logs the error and don't fail and more so if it success, it won't notify the user about it.

This is alright in normal situations but can be a bit obscure in tooling, for example: https://github.com/jcchavezs/jaeger2zipkin/blob/master/Main.php#L53

One option is to add a debug log line on success. Any ideas @anuraaga @adriancole @basvanbeek ?

@codefromthecrypt
Copy link
Member

in java we use metrics for this, and the metrics handler could be overridden to use console if you wanted. granted in java, typically the underlying http libraries can log something so we don't have as much need to redo that.

putting logging on a common path can be tricky, so if you do be careful and guard it well so that it isn't on. normal users should not need to ever see this.

@jcchavezs
Copy link
Contributor Author

We used to use metrics too but we dropped as none used and also it was hard to know what error was it (e.g. on debug as we are using curl underneath).

@codefromthecrypt
Copy link
Member

as logging can flood the console, we only handle first error at warn level (this is in the async reporter) then FINE afterwards (similar to DEBUG level) openzipkin/zipkin-reporter-java#155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants