Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zipkin-instrumentation-express outdated for express-http-proxy #204

Closed
jonesg504 opened this issue Apr 6, 2018 · 5 comments
Closed

zipkin-instrumentation-express outdated for express-http-proxy #204

jonesg504 opened this issue Apr 6, 2018 · 5 comments

Comments

@jonesg504
Copy link

zipkin-instrumentation-express is using removed functions from express-http-proxy and will not work.

functions decorateReq and intercept are removed from the library and replaced with proxyReqOptDecorator and userResDecorator

See: https://www.npmjs.com/package/express-http-proxy
@DailunCheng
Copy link

I think it's mentioned in #151

@jcchavezs
Copy link
Contributor

Is this still an issue? Ping @ghermeto

@jcchavezs
Copy link
Contributor

@jonesg504 does using connect instrumentation fix the issue?

@jcchavezs
Copy link
Contributor

I am going to explore this issue next week as I am more familiar with express now.

@jcchavezs
Copy link
Contributor

I will close this as duplicated with #151.

@jcchavezs jcchavezs mentioned this issue Jul 27, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcchavezs @jonesg504 @DailunCheng