Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dot not fail when package hash configuration is skip #18

Open
EkkoG opened this issue Mar 15, 2023 · 5 comments · May be fixed by #40
Open

Dot not fail when package hash configuration is skip #18

EkkoG opened this issue Mar 15, 2023 · 5 comments · May be fixed by #40

Comments

@EkkoG
Copy link
Contributor

EkkoG commented Mar 15, 2023

When the package skips the hash check, SDK will alert a WARM log, and the action will exit cause the WARM https://github.com/openwrt/gh-action-sdk/blob/74b0fee6a8bbd43306ececc50698637f946ddaf8/entrypoint.sh#LL75C28-L75C28

I think it should pass when package config skip hash check
@EkkoG EkkoG mentioned this issue Mar 15, 2023
Open
@EkkoG
Copy link
Contributor Author

EkkoG commented Mar 17, 2023

How read PKG_HASH from the Makefile before building?

@aparcar
Copy link
Member

aparcar commented Apr 15, 2023

Do you mean like after updating the version, how to get the new PKG_HASH?

@EkkoG EkkoG closed this as completed Apr 20, 2023
@spvkgn
Copy link

spvkgn commented Jul 31, 2023

This issue is still exist. When Makefile contains PKG_HASH:=skip the action fail with Package HASH check failed message. Maybe reopen?

@qwerttvv qwerttvv mentioned this issue Mar 8, 2024
Open
@qwerttvv
Copy link

qwerttvv commented Mar 8, 2024 •
edited
Loading

Has the problem been solved?

@EkkoG @spvkgn

I've opened a new issue. #35

azrdev added a commit to azrdev/snapos that referenced this issue Jun 19, 2024
@azrdev
ipk Makefile add source tarball hash to unbreak build
4dedda3 
skipping not possible from CI action, see
openwrt/gh-action-sdk#35
openwrt/gh-action-sdk#18
@EkkoG EkkoG reopened this Oct 29, 2024
@EkkoG
Copy link
Contributor Author

EkkoG commented Oct 29, 2024

Do you mean like after updating the version, how to get the new PKG_HASH?

@aparcar I want to read PKG_HASH before build to check if PKG_HASH's value is skip, if is skip, remove some entry from badhash_msg

@cmangla cmangla linked a pull request Nov 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add FIXUP option, for automatic package hash. cmangla/gh-action-sdk
4 participants
@EkkoG @spvkgn @aparcar @qwerttvv