Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Timeseries migration script does not handle singal metrics #586

Open
pandafy opened this issue Jul 2, 2024 · 0 comments · May be fixed by #604
Open

[bug] Timeseries migration script does not handle singal metrics #586

pandafy opened this issue Jul 2, 2024 · 0 comments · May be fixed by #604
Labels
bug Something isn't working

Comments

@pandafy
Copy link
Member

pandafy commented Jul 2, 2024

In PR #368, we modified the structure for storing metrics in the time series database. However, this update did not include restructuring the signal metrics. As a result, the signal metrics are still being written with interface name as the metric key.

Additionally, the time series migration script introduced in PR #368 does not account for signal metrics and would inadvertently delete signal data if executed on the database.

Required fixes

  1. Restructure Signal Metrics: Update the signal metrics to align with the traffic and wifi_clients metrics.
  2. Update Migration Script: Modify the time series migration script to handle signal metrics correctly and prevent data loss.
@pandafy pandafy added the bug Something isn't working label Jul 2, 2024
pandafy added a commit that referenced this issue Jul 29, 2024
@pandafy
[fix] Fixed timseries structure for storing signal metric #586
5b14521 
Updated timeseries migration script to also handle signal metrics.

Fixes #586
@pandafy pandafy linked a pull request Jul 29, 2024 that will close this issue
Open
pandafy added a commit that referenced this issue Jul 29, 2024
@pandafy
[fix] Fixed timseries structure for storing signal metric #586
9281367 
Updated timeseries migration script to also handle signal metrics.

Fixes #586

Signed-off-by: Gagan Deep <[email protected]>
pandafy added a commit that referenced this issue Jul 29, 2024
@pandafy
[fix] Fixed timseries structure for storing signal metric #586
d727ae9 
Updated timeseries migration script to also handle signal metrics.

Fixes #586

Signed-off-by: Gagan Deep <[email protected]>
pandafy added a commit that referenced this issue Jul 29, 2024
@pandafy
[fix] Fixed timseries structure for storing signal metric #586
070ba3a 
Updated timeseries migration script to also handle signal metrics.

Fixes #586

Signed-off-by: Gagan Deep <[email protected]>
pandafy added a commit that referenced this issue Jul 29, 2024
@pandafy
[fix] Fixed timseries structure for storing signal metric #586
04b2fb0 
Updated timeseries migration script to also handle signal metrics.

Fixes #586

Signed-off-by: Gagan Deep <[email protected]>
pandafy added a commit that referenced this issue Jul 29, 2024
@pandafy
[fix] Fixed timseries structure for storing signal metric #586
e3b1cfb 
Updated timeseries migration script to also handle signal metrics.

Fixes #586

Signed-off-by: Gagan Deep <[email protected]>
pandafy added a commit that referenced this issue Jul 29, 2024
@pandafy
[fix] Fixed timseries structure for storing signal metric #586
f8bfb56 
Updated timeseries migration script to also handle signal metrics.

Fixes #586

Signed-off-by: Gagan Deep <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
OpenWISP Contributor's Board
Status: To do (general)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix] Fixed timseries structure for storing signal metric #586 openwisp/openwisp-monitoring
1 participant
@pandafy