Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BINARY format #51

Open
carlosalberto opened this issue Mar 5, 2020 · 4 comments
Open

Support BINARY format #51

carlosalberto opened this issue Mar 5, 2020 · 4 comments

Comments

@carlosalberto
Copy link

As per this only TEXT_MAP format is supported.

I think support for BINARY could be added as an option for the user to explicitly specify, and keep TEXT_MAP as the default.

@carlosalberto
Copy link
Author

cc @spiliopoulos

@malafeev
Copy link
Contributor

malafeev commented Mar 6, 2020

I don't see how we can add support for Binary.
Binary adapters requires ByteBuffer.
We inject/extract context to/from Metadata.
But Metadata doesn't provide access to byte array or byte buffer.

@carlosalberto
Copy link
Author

What about https://github.com/grpc/grpc-java/blob/master/api/src/main/java/io/grpc/Metadata.java#L76 ? Would that help? Let me know. If it's truly not possible, lets close this item.

Else we can keep it as a potential enhancement ;) (not an urgent thing, that is)

@malafeev
Copy link
Contributor

I think I need more time to evaluate how binary context can be injected. I didn't see usage of it in java instrumentations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants