Add pd daemon service #2360
Open
Add pd daemon service #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2360 +/- ##
===========================================
- Coverage 55.77% 45.41% -10.37%
===========================================
Files 87 94 +7
Lines 6890 9914 +3024
Branches 0 749 +749
===========================================
+ Hits 3843 4502 +659
- Misses 3047 5193 +2146
- Partials 0 219 +219 ☔ View full report in Codecov by Sentry. |
sherysheng
requested review from
erjiaqing,
alinlazar,
Irving-cl and
superwhd
and removed request for
alinlazar
Irving-cl
reviewed
Jul 5, 2024
Irving-cl
reviewed
Jul 5, 2024
superwhd
reviewed
Jul 5, 2024
erjiaqing
reviewed
Jul 8, 2024
23 tasks
|
@jwhui @sherysheng Can we prioritize getting this change in soon? It appears we're waiting on this for some PD client qualifying tests in certification. |
superwhd
reviewed
Oct 15, 2024
| logging.info("Successfully restarted dhcpcd service.") | ||
| except subprocess.CalledProcessError as e: | ||
| logging.error(f"Error restarting dhcpcd service: {e}") | ||
| elif new_state == "stopped": |
There was a problem hiding this comment.
Should this also consider disabled?
erjiaqing
reviewed
Oct 15, 2024
| elif new_state == "stopped": | ||
| if os.path.isfile("/etc/dhcpcd.conf.orig"): | ||
| try: | ||
| subprocess.run(["sudo", "cp", "/etc/dhcpcd.conf.orig", "/etc/dhcpcd.conf"], check=True) |
There was a problem hiding this comment.
Where do you create /etc/dhcpcd.conf.orig?
There was a problem hiding this comment.
Also, please consider use shutil.
Would suggest:
- cp /etc/dhcpcd.conf.orig /etc/dhcpcd.conf.tmp
- mv /etc/dhcpcd.conf.tmp /etc/dhcpcd.conf
To make use of the atomic feature of move.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscribe Dhcp6PdState signal, start dhcpcd when state change to running,recover default dhcpcd.conf when state is stopped
local test log:
Terminal #1:
sherys@raspberrypi:~ $ python3 dhcp6_pd_daemon.py
2024-07-06 03:35:31,718 - INFO - Connected to D-Bus signal.
2024-07-06 03:35:41,577 - INFO - Dhcp6PdState changed to: running
2024-07-06 03:35:42,182 - INFO - Successfully restarted dhcpcd service.
Terminal #2:
Terminal #3:
signal time=1719724170.782791 sender=:1.32 -> destination=(null destination) serial=14 path=/io/openthread/BorderRouter/wpan0; interface=org.freedesktop.DBus.Properties; member=PropertiesChanged
string "io.openthread.BorderRouter"
array [
dict entry(
string "Dhcp6PdState"
variant string "running"
)
]
array [
]
signal time=1719724369.495711 sender=:1.32 -> destination=(null destination) serial=16 path=/io/openthread/BorderRouter/wpan0; interface=org.freedesktop.DBus.Properties; member=PropertiesChanged
string "io.openthread.BorderRouter"
array [
dict entry(
string "Dhcp6PdState"
variant string "disabled"
)
]
array [
]