Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing .gitmodules after addition of octane submodule #345

Open
ederlf opened this issue Dec 1, 2023 · 0 comments
Open

Missing .gitmodules after addition of octane submodule #345

ederlf opened this issue Dec 1, 2023 · 0 comments

Comments

@ederlf
Copy link

ederlf commented Dec 1, 2023

  1. What did you do? If possible, provide a simple script for reproducing the error.

Octane was added as a submodule, but the .gitmodules file was not included. 
It will fail if we clone and try to update the git submodules:

git submodule update --init                               

I could add it manually, but for automatic builds where we run `git submodule update --init` it would be nice to have the modules in place.

  1. What did you expect to see?

git submodule update --init  should not fail and output something like below:

Submodule 'ci/octane' (https://github.com/laravel/octane.git) registered for path 'ci/octane'
Cloning into '/tmp/ext-openswoole/ci/octane'...
Submodule path 'ci/octane': checked out '7ba4282697dd4f3d58704139cf02a5dfaad4e86c'
  1. What did you see instead?

fatal: No url found for submodule path 'ci/octane' in .gitmodules 

  1. What version of OpenSwoole are you using (show your php --ri openswoole)?
v22.1.0
  1. What is your machine environment used (show your uname -a & php -v & gcc -v) ?
Not really relevant.

You can also try the following OpenSwoole support channels:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants