Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature branch: feature/acert-cli #845

Open
JonathanWilbur opened this issue Sep 19, 2024 · 3 comments
Open

feature branch: feature/acert-cli #845

JonathanWilbur opened this issue Sep 19, 2024 · 3 comments

Comments

@JonathanWilbur
Copy link

Feature Branch Name: feature/acert-cli
Estimated Time to Completion: End of year 2024 (The code was already written; it just needs review)

There is currently no issue for this, but I can create one if requested. This feature-branch was requested by OpenSSL maintainers as a result of this PR: openssl/openssl#25441.

I will re-iterate my opinion that we should not actually create a feature-branch for this, which I stated here:

Actually, I take that back. I know I am outnumbered here, but I don't think this should be in a feature branch at all. This PR (which is not really that big overall), can be split into several smaller PRs already, each of which are individually useful, and they could be merged in any any order. I could create a PR for a CLI that supports no signing and verification and only printing, or I could create a PR that supports signing and verifying attribute certificates with no CLI, and even these can be broken down further into useful atoms.

The overhead of repeatedly having to rebase and the possibility of these changes not making it into 3.5.0 because they are collectively only 90% done does not sound worth it to me.

But that is just a point made about the technical usefulness of a feature branch. If you still want a feature branch as an administrative formality, I will still do whatever you want.

@JonathanWilbur
Copy link
Author

@t-j-h Hello, I believe I am blocked on doing this work on there being a feature branch. Can one be created for this?

@t8m
Copy link
Member

t8m commented Oct 8, 2024

+1 to create the branch.

@t8m
Copy link
Member

t8m commented Oct 8, 2024

@t-j-h could you please ack it formally here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

No branches or pull requests

2 participants