Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Performance data from initial ubuntu/macosx and identify areas to improve #641

Closed
Tracked by #577 ...
nhorman opened this issue May 31, 2024 · 3 comments
Closed
Tracked by #577 ...
Assignees
Labels
Spike Timeboxed issue
Milestone

Comments

@nhorman
Copy link
Contributor

nhorman commented May 31, 2024

Need to look a the performance data captured via issue #579 and potentially create tasks for improvement in the tracking epic

@nhorman nhorman changed the title Review Performance data on Ubuntu 22.04 and identify areas to improve Review Performance data from initial ubuntu/macosx and identify areas to improve Jun 3, 2024
@nhorman nhorman added this to the 3.4.0 milestone Jun 17, 2024
@nhorman nhorman modified the milestones: 3.4.0, 3.5.0 Jul 30, 2024
@nhorman nhorman added the Spike Timeboxed issue label Aug 26, 2024
@nhorman nhorman modified the milestones: 3.4.0, 3.5.0 Sep 5, 2024
@Sashan
Copy link

Sashan commented Sep 12, 2024

perf-plots.tgz
the tar.gz file contains a shell script which generates barcharts from run-perf.pl output.

the master branch performs lot better than 3.0.
when comparing with 1.1.1 performance vary. Some tests are better some worse.
It also varies from platform to platform. This may suggest that test runs into
limits imposed by OS/platform itself. To analyze those cases we need to gather
profiling data to see where CPU cycles are spent.

@Sashan
Copy link

Sashan commented Sep 12, 2024

profile FreeBSD on x86 (#834)
profile FreeBSD on x86_64 (#835)
profile MacOS on x86 (#836)
profile Win x86 (#837)
profile Win x86_64 (#838)
profile debian 11 x86 (#839)
profile debian 11 x86_64 (#840)
profile Ubuntu 22.04 x86_64 (#841)

@Sashan
Copy link

Sashan commented Sep 12, 2024

please review the charts attached in this in tar.gz And also gnuplot script The script processes data produced by run-perf.pl script. The script already records average results for tests, so the variation in data should be minimized.

on some platforms some data point to some problem/glitch encountered when running the performance test. for example results for newrawkey test for 1.1.1 look really odd. I suggest to re-run the test first in cases like that.

Also x509storeissuer test performance varies platform to platform, the regression was spotted on just few of them

I suggest to review generated .png files using xv *

@Sashan Sashan closed this as completed Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spike Timeboxed issue
Projects
Status: Done
Development

No branches or pull requests

2 participants