Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Highlight first pin" option is cluttered in macOS #452

Open
showier-drastic opened this issue May 25, 2024 · 2 comments
Open

"Highlight first pin" option is cluttered in macOS #452

showier-drastic opened this issue May 25, 2024 · 2 comments

Comments

@showier-drastic
Copy link

showier-drastic commented May 25, 2024

image

The three radio buttons are overlapped.

Plugin version: 2.9.0
Kicad version: 8.0.2
on macOS 14.3.1 (ARM)

@showier-drastic
Copy link
Author

showier-drastic commented May 25, 2024

This seems to be a bug of wxWidgets (or wxpy) bundled by KiCad. Reported upstream (https://gitlab.com/kicad/code/wxWidgets/-/issues/14).

A minimal reproducible example:

import wx

class Frame(wx.Frame):
    def __init__(self, title):
        wx.Frame.__init__(self, None, title=title, pos=(150,150), size=(350,200))
        panel = wx.Panel(self)
        box = wx.BoxSizer(wx.VERTICAL)

        highlightPin1Choices = [ u"None", u"All", u"Selected" ]
        self.highlightPin1 = wx.RadioBox(panel, wx.ID_ANY, u"Highlight first pin", wx.DefaultPosition, wx.DefaultSize, highlightPin1Choices, 3, wx.RA_SPECIFY_COLS )
        self.highlightPin1.SetSelection( 0 )
        box.Add( self.highlightPin1, 0, wx.ALL|wx.EXPAND, 5 )

        panel.SetSizer(box)
        panel.Layout()

app = wx.App()
top = Frame("a")
top.Show()
app.MainLoop()

Upstream wxWidgets and wxpy:

image

KiCad bundled wxpy:

image

@qu1ck
Copy link
Member

qu1ck commented May 25, 2024

Thanks for checking if it reproduces on upstream, it does seem like something is wrong in kicad's fork of wx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants