Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot try due large forces #2

Open
raimis opened this issue Sep 12, 2022 · 4 comments
Open

Cannot try due large forces #2

raimis opened this issue Sep 12, 2022 · 4 comments

Comments

@raimis
Copy link

raimis commented Sep 12, 2022

According to the description, SPICE.hdf5 is downloaded from https://github.com/openmm/spice-dataset/releases:

The script `createSpiceDataset.py` converts the dataset file SPICE.hdf5 downloaded from https://github.com/openmm/spice-dataset/releases
to the format used by [TorchMD-Net](https://github.com/torchmd/torchmd-net). It generates a new file SPICE-processed.hdf5

The file contains samples with large force (openmm/spice-dataset#32) and createSpiceDataset.py doesn't filter them.

When I try to train the loss just fluctuates ~1e7 without any improvement.

@raimis
Copy link
Author

raimis commented Sep 12, 2022

@peastman could you clarify the force cutoff? And how did you apply it?

@peastman
Copy link
Member

The filtering was implemented in openmm/spice-dataset#41, which was merged after that release was created. Once we're agreed on all remaining changes (especially anything for openmm/spice-dataset#42), I'll create a 1.1 release.

@raimis
Copy link
Author

raimis commented Sep 13, 2022

@peastman the cutoff in openmm/spice-dataset#41 is 1 Hartree/Bohr (≈ 49132 kJ/mol/nm), while in the email you mentioned 20000 kJ/mol/nm. Which ones was used?

@peastman
Copy link
Member

My original model described in the first draft of the paper used 20,000 kJ/mol/nm. The five newer models described in the current draft used 1 hartree/bohr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants