Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename random_lcg to more explanatory name #3135

Open
rzehumat opened this issue Sep 18, 2024 · 0 comments
Open

Rename random_lcg to more explanatory name #3135

rzehumat opened this issue Sep 18, 2024 · 0 comments

Comments

@rzehumat
Copy link
Contributor

Description

This is related to #2486 .

The files containing Random number generator are

However, as PCG is now used, the name random_lcg looks a bit misleading. I was wondering if other name -- maybe random or random_pcg would be better.

Alternatives

The easiest alternative to renaming would be to keep it as it is, since renaming the code, which is used quite often, might cause merge conflicts to pull requests opened before such change.

Compatibility

Renaming might result in merge conflicts. so it might be dangerous. On the other hand, other name can be more explanatory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant