Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡️(api) fonzie:acl:report view may not safely scale #17

Open
rmoch opened this issue May 17, 2019 · 0 comments
Open

⚡️(api) fonzie:acl:report view may not safely scale #17

rmoch opened this issue May 17, 2019 · 0 comments
Labels
improvement needs help

Comments

@rmoch
Copy link
Contributor

rmoch commented May 17, 2019 •
edited by jmaupetit
Loading

Description

When solving issue openfun/openedx-docker#106 (Controlling access to instructor dashboard CSV export files) we had to determine if user requesting the file was belonging to course staff.

Solution implemented by #15 may not safely scale if user belongs to a large amount of courses because we request ORM for an unknown number of lines and then calculate each course key sha1

Considered solutions

  • Retrieve course_key from HTTP referer
  • Implement specific DjangoStorage
  • Override view listing available files (list_report_downloads) to append course_key to filenames
  • Monkey patch edX ReportStore class

None of these solutions were considered satisfying.
@rmoch rmoch changed the title fonzie:acl:report view may not safely scale ⚡️(api) fonzie:acl:report view may not safely scale May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement needs help
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmoch @jmaupetit