Do not preprocess navigation_menu.

[Joaoeduardoramos]

With the introduction of the core 'navigation' module from 10.3 onwards, the 'navigation_menu' theme is introduced. Like the toolbar, it is a menu more focused on website administration.

See https://www.drupal.org/node/3443691 .

[drishu]

Can you explain more on how the processing affects the menu, what the exact issue is that the pr fixes?

[Joaoeduardoramos]

Can you explain more on how the processing affects the menu, what the exact issue is that the pr fixes?

Hi @drishu ,

the preprocess create an array structure that is not compatible with the navigation module menu items.
Producing the following warning (at least on my side):

"Undefined array key "url" in Drupal\oe_bootstrap_theme\MenuPreprocess->menuLink() (line 165 of themes/contrib/oe_bootstrap_theme/src/MenuPreprocess.php)."

Also, the module provides its own template for concerning menu: https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/navigation/templates/navigation-menu.html.twig

Finally, I believe it's the same rationale applies to the removal of the 'menu__toolbar' hook. It’s a menu primarily intended for website administration, and I would say it should not be confused with the default theme if they do not match.