-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Course Search] Refinements to search modal UX #211
[Course Search] Refinements to search modal UX #211
Comments
@bradenmacdonald Just had a few questions about this:
For this one we want to make the changes in the paragon repo rather than styling in the course authoring mfe right?
I wasn't able to reproduce this. I only get the This course All courses Was this a specific case/condition where this occurs?
I wasn't able to reproduce this as well. I can still open the "Type" filter when there are no results found, and shows me a similar message to the "Tags" filter: I tried it for both searching "This course" and "All courses". Was there also a special condition where this happens? |
That's right, it should be fixed as generally as possible. You can see the bug on https://paragon-openedx.netlify.app/components/searchfield/#with-the-submit-button-outside-the-input . For the others, hmm, maybe the latest version wasn't on the sandbox. Let's check again in a few days after all the current PRs are merged. Perhaps it's already done. |
@bradenmacdonald Got it 👍 , thanks! |
@bradenmacdonald Regarding the paragon bug, after looking into it I just wanted to confirm I understood the issue properly. In both cases, in our keyword search field and in the searchfield in the paragon docs you linked, the border radius in both is being set in the styles to be 0 (making it a square/rectangle), but the focus state remains on the original border radius. The original border radius is being set/calculated here, from what I understand from the code, that should be automatically handling border radius overrides but the bug is that it currently isn't? |
@yusuf-musleh Ah, I see. I forgot how it worked. I guess it would be enough to just fix the CSS in course-authoring, where it makes the border square to also make the focus rectangle square. But we should open an issue on Paragon saying that the current Open edX theme doesn't provide a way to "force" buttons to be square easily, and show that the "SearchField"'s default submit button's focus rect doesn't match its border shape. |
@bradenmacdonald Make sense, thanks for the clarification. I'll make the style change in course authoring and create a issue in paragon mentioning the above. |
@bradenmacdonald Opened the issue on Paragon: openedx/paragon#3038 |
@yusuf-musleh Based on some feedback from @ali-hugo, I added two items above in the description (6 and 7) - please take a look. |
Fixes to Paragon:
Fixes to our content search modal:
Other fixes if possible:
The text was updated successfully, but these errors were encountered: