Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tagging] Show tag count for each tagged component on the Unit Page #158

Closed
bradenmacdonald opened this issue Dec 1, 2023 · 4 comments · Fixed by openedx/edx-platform#33928

Comments

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Dec 1, 2023

On the unit page, when a component (XBlock) has at least 1 tag, the tag count button should appear, just like for units on the course outline page. Clicking it should open the tag drawer.

Screenshot 2023-12-01 at 10 18 00 AM

Should have the same button as seen on units on the outline:

Screenshot 2023-12-01 at 10 19 19 AM

Acceptance criteria

  1. Components with no tags do not display the button
  2. Components with 1+ tag(s) do display the button
  3. The tag count for all the components on the page is loaded at once. (use , to separate component IDs with this API)
  4. Update the wiki page at https://openedx.atlassian.net/wiki/spaces/COMM/pages/3866689562/New+Additions+to+the+Course+Unit+Page to mention this new feature.
@bradenmacdonald
Copy link
Contributor Author

FYI @jmakowski1123 @ali-hugo

@jmakowski1123
Copy link

@bradenmacdonald , is the prior art at the unit level enough to implement this, or do you need a mock?

@bradenmacdonald
Copy link
Contributor Author

bradenmacdonald commented Dec 1, 2023

@jmakowski1123 @ali-hugo Here's what it would look like if we basically copy the code from the outline onto the unit page. If this looks good, we'll go with it; if you want something that looks different, a mock would be helpful.

Screenshot 2023-12-01 at 11 56 00 AM

Screenshot 2023-12-01 at 11 56 14 AM

Note for devs: for this mock, I copied the <li> code and had to change the <a> to a button.btn-default.action-button to get it to look OK.

@ali-hugo
Copy link

ali-hugo commented Dec 4, 2023

@bradenmacdonald What you have in the screenshot above is perfect. I've updated the design files to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants