Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: define app entry point for webpack.dev.config.js #726

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

adamstankiewicz
Copy link
Member

Description:

Without defining the app entrypoint explicitly, HtmlWebpackPlugin does not have assets available for app when its referenced in the chunks option.

The webpack.common.config.js in frontend-build defines an app entrypoint, but the frontend-platform example app overrides it.

Merge checklist:

  • Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
  • Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
  • Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

  • After the build finishes for the merged commit, verify the new release has been pushed to NPM.

@adamstankiewicz adamstankiewicz marked this pull request as ready for review August 30, 2024 20:29
@adamstankiewicz adamstankiewicz changed the title fix: define app entry point for webpack.dev.config.js chore: define app entry point for webpack.dev.config.js Aug 30, 2024
@adamstankiewicz adamstankiewicz merged commit 751a691 into master Aug 30, 2024
5 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/update-entry-point branch August 30, 2024 20:31
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (c878cce) to head (20deb19).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #726   +/-   ##
=======================================
  Coverage   83.41%   83.41%           
=======================================
  Files          40       40           
  Lines        1073     1073           
  Branches      197      197           
=======================================
  Hits          895      895           
  Misses        166      166           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants