Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test to useParagonTheme hook and paragon utils #525

Merged

Conversation

dcoa
Copy link
Contributor

@dcoa dcoa commented Jul 25, 2023

Description:

This is a testing contribution to Theming Configuration in Runtime, covering useParagonTheme hook, and the utils file.

Context: #440

C.C @adamstankiewicz

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 25, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 25, 2023

Thanks for the pull request, @dcoa! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +3.40% 🎉

Comparison is base (cf10278) 79.05% compared to head (2303087) 82.45%.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           ags/inject-theme-css     #525      +/-   ##
========================================================
+ Coverage                 79.05%   82.45%   +3.40%     
========================================================
  Files                        48       48              
  Lines                      1351     1351              
  Branches                    283      283              
========================================================
+ Hits                       1068     1114      +46     
+ Misses                      251      217      -34     
+ Partials                     32       20      -12     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211
Copy link

Hi @dcoa - is this ready for review?

cc: @adamstankiewicz

@dcoa
Copy link
Contributor Author

dcoa commented Aug 3, 2023

Hi @mphilbrick211, yes, it is

@mphilbrick211 mphilbrick211 requested a review from a team August 7, 2023 17:59
@mphilbrick211
Copy link

Hi @openedx/fed-bom! Would someone be able to review / merge this for us?

it('should remove all the links in the DOM', () => {
document.head.innerHTML = `
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@edx/paragon@$21.0.0/dist/core.min.css">
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@edx/brand@$2.0.0Version/dist/core.min.css">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the version in this href URL is incorrectly formatted, i.e. $2.0.0Version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I fixed it, thanks

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 9, 2023
@dcoa
Copy link
Contributor Author

dcoa commented Sep 4, 2023

Hi, @adamstankiewicz, any additional feedback?

@mphilbrick211
Copy link

Hi, @adamstankiewicz, any additional feedback?

Hi @adamstankiewicz! Friendly ping on this.

@mphilbrick211
Copy link

Hi @openedx/fed-bom @adamstankiewicz! Is this something you could please review / merge for us? Thanks!

@jmbowman
Copy link

Some context for FED-BOM from @adamstankiewicz :

This is adding test coverage for this open PR, related to the Paragon design tokens work: #440

As the owners of frontend-platform, would love FED-BOMs review on both, about the specific implementation but also the high level approach! It's been awhile since these PRs have been touched, though, and need additional QA... It's related to the design tokens project the Raccoon Gang Paragon engineers have been working on in the background for awhile now. The frontend-platform changes are the proposed mechanism to load the external Paragon theme CSS generated by the design tokens project, hosted from a CDN url.

I believe the changes are additive-only, where this frontend-platform PR and the associated frontend-build PR could be released to master without a breaking change.

Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @dcoa! Apologies for the delayed review.

@adamstankiewicz adamstankiewicz merged commit b5f1588 into openedx:ags/inject-theme-css Dec 9, 2023
5 checks passed
@openedx-webhooks
Copy link

@dcoa 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

dcoa added a commit to eduNEXT/frontend-platform that referenced this pull request Dec 30, 2023
dcoa added a commit to eduNEXT/frontend-platform that referenced this pull request Jan 3, 2024
dcoa added a commit to eduNEXT/frontend-platform that referenced this pull request Apr 4, 2024
bra-i-am pushed a commit to eduNEXT/frontend-platform that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants