Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade to Node 20 #447

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Sep 25, 2024

Description

  • Regenerated package-lock.json with node v20 and NPM 10.
  • Updated .nvmrc to v20
  • An error occurred when building node-sass with Node v20, as the binary failed to load (ERR_DLOPEN_FAILED). The error was resolved by upgrading node-sass and sass-loader.
  • Updated Babel packages to resolved failing tests due to version mismatch (Error: Requires Babel "^7.22.0 || >8.0.0-alpha <8.0.0-beta", but was loaded with "7.16.0").

Second step in the Node 20 upgrade process, See the tracking issue for further information.

@BilalQamar95 BilalQamar95 self-assigned this Sep 25, 2024
@BilalQamar95 BilalQamar95 mentioned this pull request Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.74%. Comparing base (c74b526) to head (3ce2db2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   74.74%   74.74%           
=======================================
  Files           3        3           
  Lines          99       99           
  Branches       29       29           
=======================================
  Hits           74       74           
  Misses         19       19           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brian-smith-tcril brian-smith-tcril merged commit 44a2fb1 into master Sep 30, 2024
7 checks passed
@brian-smith-tcril brian-smith-tcril deleted the bilalqamar95/node20-upgrade-2 branch September 30, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants