Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: surface time in the enroll-by date column #1312

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

brobro10000
Copy link
Member

Surfaces the enroll by date time within the learner credit allocation table.
Updates the text within the enroll by tool tip to remove any indication of time.

Screenshot 2024-09-18 at 1 26 05 PM

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.56%. Comparing base (6c82806) to head (e23040c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1312   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files         567      567           
  Lines       12598    12598           
  Branches     2633     2670   +37     
=======================================
  Hits        10780    10780           
+ Misses       1757     1756    -1     
- Partials       61       62    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brobro10000 brobro10000 merged commit 329fae8 into master Sep 18, 2024
6 checks passed
@brobro10000 brobro10000 deleted the hu/ent-variant-bug-bash-2 branch September 18, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants