Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Retired workflow on the list policy screens #1213

Conversation

zwidekalanga
Copy link
Contributor

@zwidekalanga zwidekalanga commented May 7, 2024

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

Screenshot 2024-05-22 at 11 56 54 PM
  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@zwidekalanga zwidekalanga force-pushed the zwidekalanga/retired-budgets-policy-list branch 3 times, most recently from b615886 to 7dcc0f9 Compare May 8, 2024 13:54
Copy link
Member

@brobro10000 brobro10000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor nit

src/components/learner-credit-management/SubBudgetCard.jsx Outdated Show resolved Hide resolved
@adamstankiewicz
Copy link
Member

@zwidekalanga In addition to the Figma mock discrepancies mentioned above regarding the "Learner Credit Management" budgets overview page route, it doesn't look like this PR is tackling anything from the Figma mocks on the budget detail page route.

  • budget detail page header (Figma)
  • budget detail page "Assigned" table (Figma)
    • Heading changed to "Incomplete assignments"; help text also changed.
    • "Amount" column shows price as having a strikeout.
    • "Status" column is "Incomplete" (this would require likely API changes to the assignments list API, though, unless we opt to make this a frontend-only change; that said, I might prefer relying on the API changes so API-only customers still have the appropriate assignment state of "incomplete").
  • budget detail page "Spent" table help text.

@zwidekalanga zwidekalanga force-pushed the zwidekalanga/retired-budgets-policy-list branch 5 times, most recently from 45417b7 to e07d2ab Compare May 21, 2024 15:26
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (f3ee5ea) to head (d67bee6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1213      +/-   ##
==========================================
+ Coverage   85.33%   85.35%   +0.01%     
==========================================
  Files         537      537              
  Lines       11695    11709      +14     
  Branches     2472     2480       +8     
==========================================
+ Hits         9980     9994      +14     
  Misses       1663     1663              
  Partials       52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwidekalanga zwidekalanga force-pushed the zwidekalanga/retired-budgets-policy-list branch from 1984865 to 443148d Compare May 22, 2024 18:59
@zwidekalanga zwidekalanga force-pushed the zwidekalanga/retired-budgets-policy-list branch from 443148d to 9b2ffd6 Compare May 22, 2024 21:36
@zwidekalanga zwidekalanga force-pushed the zwidekalanga/retired-budgets-policy-list branch from 9b2ffd6 to d67bee6 Compare May 22, 2024 21:42
@adamstankiewicz adamstankiewicz merged commit eba39d7 into openedx:master May 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants