Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enterprise sso orchestrator record api client #1038

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

alex-sheehan-edx
Copy link
Contributor

https://2u-internal.atlassian.net/browse/ENT-7577

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 36.00% and project coverage change: -0.15% ⚠️

Comparison is base (e5edf15) 83.03% compared to head (ce8c6d7) 82.88%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1038      +/-   ##
==========================================
- Coverage   83.03%   82.88%   -0.15%     
==========================================
  Files         412      412              
  Lines        8857     8876      +19     
  Branches     1821     1822       +1     
==========================================
+ Hits         7354     7357       +3     
- Misses       1464     1479      +15     
- Partials       39       40       +1     
Files Changed Coverage Δ
...ttings/SettingsApiCredentialsTab/ZeroStateCard.jsx 100.00% <ø> (ø)
src/data/services/LmsApiService.js 31.35% <5.88%> (-2.58%) ⬇️
...s/SettingsApiCredentialsTab/APICredentialsPage.jsx 100.00% <100.00%> (ø)
.../settings/SettingsApiCredentialsTab/CopyButton.jsx 93.75% <100.00%> (+0.89%) ⬆️
...nents/settings/SettingsApiCredentialsTab/index.jsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alex-sheehan-edx alex-sheehan-edx merged commit 5cb3eeb into master Sep 25, 2023
4 of 6 checks passed
@alex-sheehan-edx alex-sheehan-edx deleted the asheehan-edx/ENT-7577 branch September 25, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants