Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: updated lock file version check to use new workflow #1023

Closed
wants to merge 2 commits into from

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Aug 28, 2023

Description

Renamed lockfileversion-check-v3 to lockfile-check in lockfile version file.

Ticket

Prototype a way to review NPM lockfiles in PRs

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 92.37% and project coverage change: +0.12% 🎉

Comparison is base (31f4dc8) 82.89% compared to head (41d656f) 83.01%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
+ Coverage   82.89%   83.01%   +0.12%     
==========================================
  Files         402      412      +10     
  Lines        8735     8850     +115     
  Branches     1805     1822      +17     
==========================================
+ Hits         7241     7347     +106     
- Misses       1455     1464       +9     
  Partials       39       39              
Files Changed Coverage Δ
.../components/ContactCustomerSupportButton/index.jsx 100.00% <ø> (ø)
src/components/settings/SettingsLMSTab/index.jsx 95.45% <ø> (ø)
src/data/reducers/portalConfiguration.js 73.33% <ø> (ø)
src/data/services/LmsApiService.js 33.92% <12.50%> (-1.08%) ⬇️
src/components/settings/SettingsTabs.jsx 87.87% <80.00%> (-2.45%) ⬇️
.../settings/SettingsApiCredentialsTab/CopyButton.jsx 92.85% <92.85%> (ø)
src/components/settings/HelpCenterButton.jsx 100.00% <100.00%> (ø)
...s/SettingsApiCredentialsTab/APICredentialsPage.jsx 100.00% <100.00%> (ø)
...nts/settings/SettingsApiCredentialsTab/Context.jsx 100.00% <100.00%> (ø)
...settings/SettingsApiCredentialsTab/CopiedToast.jsx 100.00% <100.00%> (ø)
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mashal-m Mashal-m marked this pull request as draft August 28, 2023 13:56
@Mashal-m Mashal-m changed the title refactor: update lock file version refactor: updated lock file version check to use new workflow Aug 31, 2023
@Mashal-m Mashal-m marked this pull request as ready for review October 2, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants