Edly: Integrate Forum V2 Application into edx-platform #35671
Conversation
Faraz32123
force-pushed
the
edly/forumv2
branch
from
24a00ff
to
59a0227
Compare
This commit introduces the new Forum V2 application, allowing users to choose between the legacy Forum V1 and the new Forum V2 at the course level. Key Changes: - Added waffle flag `forum_v2.enable_forum_v2` to enable Forum V2 for selected courses, allowing coexistence with Forum V1. - Default data storage for Forum V2 is set to MongoDB, with an option to switch to MySQL using the waffle flag `forum_v2.enable_mysql_backend`. - Introduced management command `forum_migrate_course_from_mongodb_to_mysql` for per-course data migration from MongoDB to MySQL. Note: This PR does not include all unit tests for the Forum V2 native API due to ongoing migration efforts. Further updates will follow to ensure full test coverage before final release. Co-authored-by: [Muhammad Faraz Maqsood] <[email protected]> Co-authored-by: [Ali Salman] <[email protected]>
Faraz32123
force-pushed
the
edly/forumv2
branch
from
59a0227
to
dba51e4
Compare
|
@Faraz32123 Are the unit tests complete now? Did you test the new forum v2 with the discussions MFE? |
|
| @@ -82,6 +82,7 @@ def _set_mock_request_data(self, mock_request, data): | |||
|
|
|||
|
|
|||
| @patch('openedx.core.djangoapps.django_comment_common.comment_client.utils.requests.request', autospec=True) | |||
| @patch('lms.djangoapps.discussion.toggles.ENABLE_FORUM_V2.is_enabled', autospec=True) | |||
There was a problem hiding this comment.
Why not just use @override_waffle_flag(ENABLE_FORUM_V2, True)
There was a problem hiding this comment.
Yup, that can be also used but the idea was to keep the extra patching/mocking method same.
There was a problem hiding this comment.
With that method you wouldn't need to pass around the mock, and eventually when forums v2 is the only one you can just drop the relevant code easily.
There was a problem hiding this comment.
we have created test files(those will come in next PR) that cover forum v2. So in case when we are only left with forum v2, we'll eventually remove this file completely.
|
can @regisb you or someone with access run the workflows again. Thanks. |
This PR introduces the integration of the new Forum V2 application into the edx-platform, allowing a course-level choice between the legacy forum (V1) and the new Forum V2.
Key Changes 🚀🚀:
Waffle Flag for Forum V2:
A new course waffle flag,
forum_v2.enable_forum_v2, has been introduced. When enabled, it will activate the Forum V2 application for the selected course, allowing Forum V1 and V2 to coexist in the platform, used on a per-course basis.Data Storage Options:
By default, Forum V2 stores data in MongoDB. However, if MySQL is preferred (as is the default in Tutor), an additional course waffle flag,
forum_v2.enable_mysql_backend, can be used to switch the storage backend to MySQL.Course-Level Data Migration:
A new management command,
forum_migrate_course_from_mongodb_to_mysql, enables data migration on a per-course basis from MongoDB to MySQL. This provides a smooth transition for courses already using Forum V2 with MongoDB who wish to switch to MySQL.🛠 Note that this PR does not include all unit tests for the forum v2 native API. This is because migrating unit tests is taking much longer than expected. We will take out this PR from draft as soon as it is considered production-ready, despite the fact that some code in edx-platform might not be 100% covered.