Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible issues in the default geozones file #2938

Open
tboye opened this issue Dec 10, 2023 · 1 comment
Open

Possible issues in the default geozones file #2938

tboye opened this issue Dec 10, 2023 · 1 comment

Comments

@tboye
Copy link
Contributor

tboye commented Dec 10, 2023

While migrating to udata v7 and addressing breaking changes in GeoZone, I noticed a few possible issues in the current DEFAULT_GEOZONES_FILE.

Detailed Description

  • There are two Vatican entries 🇻🇦🇻🇦
  • There might be a typo in the code of Kosovo: it's set to yk while usually it's xk
  • Namibia doesn't provide code/id

Context

Sharing my findings just in case.

Possible Implementation

N/A

Your Environment

N/A

@Pierlou
Copy link
Contributor

Pierlou commented Dec 11, 2023

Hello, thanks for your vigilance. We are using data from this dataset, published by the French Ministry of Foreign Affairs, as we believe they have very reliable information for this topic. In the source file, there are indeed two lines for Vatican (identical, except for a different phone indicator. We will deduplicate the table to correct this issue. The other two also originate from the source data: the ISO Alpha 2 code of Kosovo is yk and there is none for Namibia. We will escalate the issue to the producers, hoping they will correct it. Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants