Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF-8 characters in url cause urlhash mismatch #59

Open
abulte opened this issue Apr 19, 2018 · 1 comment
Open

UTF-8 characters in url cause urlhash mismatch #59

abulte opened this issue Apr 19, 2018 · 1 comment
Labels

Comments

@abulte
Copy link
Contributor

abulte commented Apr 19, 2018

When a resource URL holds some UTF-8 characters (eg https://raw.githubusercontent.com/etalab/format-commande-publique/master/schémas/xml/contrats-concessions.xsd), the urlhash computed by udata-piwik to try to find the resource does not match the one we have in DB. Probably because they are url-encoded in DB (eg https://raw.githubusercontent.com/etalab/format-commande-publique/master/sch%C3%A9mas/xml/contrats-concessions.xsd).

Fix: try to compute hash on an encoded url.

@abulte abulte added the bug label Apr 19, 2018
abulte added a commit to abulte/udata-piwik that referenced this issue Apr 23, 2018
@abulte
Copy link
Contributor Author

abulte commented Apr 23, 2018

After a few tests, it seems encoding of UTF-8 characters is properly handled. This problem must be triggered by something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant