Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meal planner: page flickers when meals are added / moved #156

Open
jayaddison opened this issue Jul 2, 2020 · 1 comment
Open

Meal planner: page flickers when meals are added / moved #156

jayaddison opened this issue Jul 2, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@jayaddison
Copy link
Member

Describe the bug
In the meal planner, adding or moving recipes in the weekly calendar causes the contents of the planner to momentarily flicker.

To Reproduce
Steps to reproduce the behavior:

  1. Perform a recipe search and add a recipe to a meal plan
  2. Navigate to the meal planner view
  3. Drag the added recipe onto an upcoming day of the week
  4. Observe content flickering when the recipe is dropped into the day row
  5. Move the existing recipe -- or equivalently, drag another copy of a recipe -- onto an upcoming day of the week
  6. Observe that the existing and new content both flicker when the recipe is dropped into the day row

Expected behavior
Content should maintain visibility while dragging and when dropped into a meal planner day row. Moving or otherwise adjusting items in the meal planner should not cause any flickering of any existing or newly-added items.

@jayaddison jayaddison added the bug Something isn't working label Jul 2, 2020
@jayaddison
Copy link
Member Author

This happens because we re-display the list of meals whenever the contents of the db.meals table is modified.

That's a simple and lazy approach, and the key benefit is that it makes maintaining the consistency of the database table and the view easy. The flicker occurs when the view elements are emptied during the refresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant