Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially-filter author field values that contain email addresses #25

Open
jayaddison opened this issue Nov 9, 2023 · 0 comments
Open
Labels
bug Something isn't working

Comments

@jayaddison
Copy link
Member

Describe the bug
Rarely, the author field of a recipe may return a value that contains -- or is -- an email address.

That may be OK if it's what the recipe author intended (it seems reasonable for them to choose how to display their own authorship details), but I think it'd seem a little unusual for email addresses to appear -- without appearing as mailto: hyperlinks -- in the application's search results. I don't think we want to turn them into hyperlinks, because that'd seem like it's putting those authors on a different level of authority/appearance to other recipe authors. In addition: it'd be easier to filter our database backups for the presence of email addresses -- something we don't want to appear -- if we can filter out these rare existing cases.

Short-term I think that removing the @ and domain-part of each address may be sufficient; a username / inbox name is a form of name, and each recipe result includes a hyperlink to the recipe itself (which should usually be on the same domain.. perhaps a sign of something particularly odd if the author looks like an email and doesn't match the recipe domain -- but we haven't seen that so far).

To Reproduce
Steps to reproduce the behavior:

  1. N/A (not including repro details here)

Expected behavior
Display the username part only from any email addresses found within the contents of the author field.

Screenshots
N/A (not including screenshots here)

@jayaddison jayaddison added the bug Something isn't working label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant