osc leaves commit messages in ~/.cache/

[krop]

rpm -qv osc

osc-1.6.1-1.1.noarch (also happened with 1.6.0)

osc leaves the commit messages in the cache folder when osc ci is used without -m "..."

Tested with and without the EDITOR env variable set

# du -h $HOME/.cache/osc/edited-messages 
224K    /home/krop/.cache/osc/edited-messages

# ls -l $HOME/.cache/osc/edited-messages 
total 224
-rw-r--r-- 1 krop krop  6291 28 févr. 19:16 2024-02-28_19:16:42.841086
-rw-r--r-- 1 krop krop 10620 28 févr. 19:16 2024-02-28_19:16:53.031481
-rw-r--r-- 1 krop krop  1220 28 févr. 19:43 2024-02-28_19:43:31.264329
[...]

# cat 2024-03-01_13:06:22.873559
(test) spec update
--This line, and those below, will be ignored--

M    opentoonz.spec

Diff for working copy: .
Index: opentoonz.spec
===================================================================

--- opentoonz.spec      (revision 22)
+++ opentoonz.spec      (working copy)
@@ -1,7 +1,7 @@
 #
 # spec file for package opentoonz
 #
-# Copyright (c) 2023 SUSE LLC
+# Copyright (c) 2024 SUSE LLC
 #
 # All modifications and additions to the file contributed by third parties
 # remain the property of their copyright owners, unless otherwise agreed

[dmach]

This behavior was introduced in b789cdf
The purpose was to store any edited messages that would get lost if osc fails.
They get cleaned up after 1 day (only after you open an editor from osc).
Do you consider this a problem / would you like to change the behavior?

[krop]

I see. I guess it's acceptable then, just a bit surprising that a successful commit doesn't clear the cached file immediately