Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deltatocumulative re-uses memory #35872

Open
sh0rez opened this issue Oct 18, 2024 · 1 comment
Open

deltatocumulative re-uses memory #35872

sh0rez opened this issue Oct 18, 2024 · 1 comment
Labels
bug Something isn't working needs triage New item requiring triage

Comments

@sh0rez
Copy link
Member

sh0rez commented Oct 18, 2024

Component(s)

processor/deltatocumulative

What happened?

The new Linear part of deltatocumulative does not properly clone the first datapoint, instead stores the one from the pmetric.Metrics it receives.

This leads to a racy condition where subsequent aggregations change the emitted result, possibly leading to false outputs.

To fix, change to dp.Clone() here:

Collector version

2b9ec02

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@ArthurSens
Copy link
Member

This was fixed by #35562, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage New item requiring triage
Projects
None yet
2 participants