Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/opampsupervisor] Strictly unmarshal the supervisor configuration #35838

Open
BinaryFissionGames opened this issue Oct 16, 2024 · 3 comments

Comments

@BinaryFissionGames
Copy link
Contributor

Component(s)

cmd/opampsupervisor

Describe the issue you're reporting

The supervisor configuration currently may contain keys that aren't actually configuring anything. These keys are currently ignored, and the supervisor starts happily.

The issue here is that if you typo a setting, the supervisor will not notify you of your error and the setting will be silently ignored.

Instead, we should do a strict unmarshal of the config in order to error on any extra/unknown keys being present.

@BinaryFissionGames BinaryFissionGames added the needs triage New item requiring triage label Oct 16, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@BinaryFissionGames
Copy link
Contributor Author

/label good-first-issue -needs-triage

@github-actions github-actions bot added good first issue Good for newcomers and removed needs triage New item requiring triage labels Oct 16, 2024
@Annosha
Copy link

Annosha commented Oct 17, 2024

As a beginner, I'm willing to work on it once the maintainers approve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants