Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Builds Location? #1918

Open
zorrion opened this issue Sep 11, 2024 · 4 comments
Open

Release Builds Location? #1918

zorrion opened this issue Sep 11, 2024 · 4 comments

Comments

@zorrion
Copy link

zorrion commented Sep 11, 2024

Is it possible for the project to setup a CI/CD and make a release build location for the C library so that everyone doesn't have to rebuild it constantly?

This would make it infinitely easier to test the demos etc.

If there is a release location. Can you update this issue with the location?

@SWilson4
Copy link
Member

Hi @zorrion, thanks for the suggestion. I would guess you're thinking of having binaries published with each release, for example in the "Assets" section here.

I don't think it would be too difficult to publish builds for a couple of popular configurations (e.g., x86_64 portable build / standards-track algorithms enabled). I imagine we'd have to limit it to static library builds only. Any reason not to do this @baentsch @dstebila @praveksharma?

We do have a backlog of "nice-to-have" feature requests, so if this is an addition that would save you time/effort, please consider using some of that time/effort to implement it and open a PR.

@baentsch
Copy link
Member

Any reason not to do this

Yes. Support and maintenance obligations. I had this for some time in oqsprovider but removed it as per open-quantum-safe/oqs-provider#94 (comment).

The rationale given

This would make it infinitely easier to test the demos etc.

is not quite clear to me: @zorrion we have fully-building and readily built docker images for the demos. I'd have thought that's maximum ease of use (no need to build anything, not even link the library), no?

@zorrion
Copy link
Author

zorrion commented Sep 11, 2024

@baentsch the main use case I had was integration with Python and/or Java custom codebases.

@baentsch
Copy link
Member

@baentsch the main use case I had was integration with Python and/or Java custom codebases.

@zorrion in that case, can I invite you to take a look at open-quantum-safe/oqs-provider#512 (reply in thread) and possibly provide input there as to the updating of https://github.com/open-quantum-safe/liboqs-python/blob/main/docker%2FREADME.md? A PR as suggested by @SWilson4 would be ideal, but any and all comments making things easy to consume would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

3 participants