-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMAKE_POSITION_INDEPENDENT_CODE should be optional #1882
Comments
I dug through the git blame to see why we would have hardcoded this, and it led me to PR #670, citing OpenSSL build failures. I believe that PR predated |
Good "dig" @SWilson4 . Yes, the rationale given by @kevinmkane in 2020 seems sensible when building |
In order to use OQS for an embedded target (which does not use dynamic linking, and hence does not provision a Global Offset Table or Procedure Linkage Table), I would like to build it as a static library with CMAKE_POSITION_INDEPENDENT_CODE set OFF. However, the CMakeLists.txt hard codes this to ON, with no capability to override.
It would be useful to allow this setting to be chosen from externally, for example in the CMake toolchain file.
It should be noted that CMake's default choice in the absence of a setting is usually a sensible one (depending on the type of library or executable being built).
The text was updated successfully, but these errors were encountered: