Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up Policy files in examples #515

Open
t-fine opened this issue Mar 1, 2022 · 5 comments
Open

Clean-up Policy files in examples #515

t-fine opened this issue Mar 1, 2022 · 5 comments
Assignees

Comments

@t-fine
Copy link
Collaborator

t-fine commented Mar 1, 2022

A message from Glen...
"It is unfortunate that the examples in the open-horizon/examples repo inconsistently use the horizon subdirectory and the policy subdirectory. I had forgotten how bad this was but today I am trying to write up something about how to use pattern and policy and I wanted to point at the examples repo but then rediscovered the inconsistency there."

The original reason for having two sets of policy files in the horizon and policy directories was to have one that the exchangePublish.sh script uses when populating a new exchange (the horizon dir), and one set for users to leverage when walking through the "Creating your own ..." README flow so there wouldn't be two agreements that deploy the helloworld service possible causing confusion as well.

@saurav1004
Copy link
Contributor

Hello @t-fine,
I would like to work on this issue. Could this be assigned to me ?

Also, can you guide me a little wrt what needs to be done here.

@t-fine
Copy link
Collaborator Author

t-fine commented Feb 13, 2023

Sorry about the delay here @saurav1004 have at it! :)

@saurav1004
Copy link
Contributor

No issues. I will take a look. Could you guide me a little wrt what needs to be done here, to avoid the confusion

@joewxboy
Copy link
Member

@saurav1004 Take a look at our newer example services for a good pattern or example to follow regarding files living in a single folder rather than "horizon" or "policy" directories:

@t-fine
Copy link
Collaborator Author

t-fine commented Feb 27, 2023

@saurav1004 in regards to the files in policy/ ... perhaps their creation could be worked into the steps of the "Creating Your Own Hello World Edge Service" so there is no actual file to save ... just thinking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants