Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reusing examples across independent pages #1681

Open
jpmckinney opened this issue Mar 28, 2024 · 1 comment
Open

Avoid reusing examples across independent pages #1681

jpmckinney opened this issue Mar 28, 2024 · 1 comment
Labels
blocked We can't merge this yet Focus - Examples Relating to examples in the guidance
Milestone

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Mar 28, 2024

Review (:file:|include}) (\.\./)?\.\./examples/ to check whether the examples/ folder matches the page.

If it doesn't (like amendments/tender.json being used in schema/merging, schema/records_reference and schema/packaging/record_package), then move it to a different directory or make a copy, as it's not expected that updating the amendments example could change the explanation on another page.

Do this once current examples-related PRs merged.

@jpmckinney jpmckinney added the Focus - Examples Relating to examples in the guidance label Mar 28, 2024
@jpmckinney jpmckinney added this to the 1.2.0 milestone Mar 28, 2024
@jpmckinney
Copy link
Member Author

I did a quick review now and I think it's the only one.

@odscjen odscjen added the blocked We can't merge this yet label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked We can't merge this yet Focus - Examples Relating to examples in the guidance
Projects
Status: To do
Development

No branches or pull requests

2 participants