Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explaining the documentation structure #1215

Closed
JachymHercher opened this issue Feb 14, 2021 · 7 comments · Fixed by #1510
Closed

Explaining the documentation structure #1215

JachymHercher opened this issue Feb 14, 2021 · 7 comments · Fixed by #1510
Assignees
Labels
Focus - UX Making information easier to find and interpret quick Ready for PR Schema Relating to other changes in the JSON Schema (renamed fields, schema properties, etc.)
Milestone

Comments

@JachymHercher
Copy link
Contributor

JachymHercher commented Feb 14, 2021

As a reader of the OCDS documentation, it is not clear to me what is the relationship between / what to expect of "Getting Started", "Guidance" and certain parts of "Reference" (esp. "Merging", "Identifiers" and "Conformance and extensions").

My best guess is:

  • "Getting Started" is something like "understanding what OCDS is" / "very basic info"
  • "Guidance" is something like "step by step guidance when you are implementing" / "more advanced info"
  • "Reference" is normative, while the above-mentioned are not normative.

I would suggest the following changes:

@JachymHercher JachymHercher added the Focus - Documentation Includes corrections, clarifications, new guidance, and UI/UX issues label Feb 14, 2021
@JachymHercher JachymHercher added this to the 1.2.0 milestone Feb 14, 2021
@jpmckinney
Copy link
Member

Thanks, @JachymHercher. @EricReese15's work on the Primer (and home page) can address the first two bullets. For the last bullet, we'll have to do this iteratively. The new theme that @choldgraf is working on will help with the navigational issues.

@jpmckinney
Copy link
Member

For the third bullet, could you give some examples? Once that's clearer, we can start to list which content ought to move.

@JachymHercher JachymHercher self-assigned this Jul 29, 2021
@JachymHercher
Copy link
Contributor Author

Point 1 and 2 are indeed covered by the new primer, specifically:

Guidance: Step-by-step instructions on how to design and implement an OCDS publication, including practical examples
Reference: The OCDS data model (schemas, codelists and validation rules) as well as specific rules that need to be followed to publish OCDS data

It doesn't explicitly use the word "normative", but that makes sense, as it's jargon.


Concerning point 3, my assumption is that everything we want people to do according to the Guidance (esp. hard cases) must be based on some text (typically a description of a field or code) in Reference. The purpose of Guidance is just to draw together the "rules" from Reference and give them to the users in an easy-to-understand way. If this assumption correct, then I'm unsure whether the following instructions in Guidance have a corresponding basis in Reference:

  1. Do we set somewhere in Reference that for multistage processes you need multiple ocids? It's not in https://standard.open-contracting.org/latest/en/schema/identifiers/#contracting-process-identifier-ocid, just in https://standard.open-contracting.org/latest/en/guidance/map/related_processes/.

  2. Do we set somewhere in Reference when to put information only in awards, when only in contracts and when in both? Along the lines of https://standard.open-contracting.org/latest/en/guidance/map/awards_contracts/#id1, cf. Guidance on awards and contracts: when to fill in one and/or the other #1400.

  3. According to https://standard.open-contracting.org/latest/en/guidance/map/organizational_units/, additionalIdentifiers can be used to provide unit identifiers, but this is not reflected in the field's description.

  4. According to guidance/map/contracting_planning_processes.md (pull 1216, merged into OCDS 1.2)

    A planning process ought to have its releaseTag set to 'planning' (or 'planningUpdate'). A contracting process can have releaseTag set to any other value from the codelist. A planning process should not contain the releaseTag 'tender' even if it contains a tender object. The two processes ought to be linked together using the relatedProcesses array in the releases for the contracting process, with the 'planning' code in the related process' relationship array.

    Shouldn't the sentence "A planning process should not contain the releaseTag 'tender' even if it contains a tender object." also be somewhere in Reference?

@jpmckinney
Copy link
Member

jpmckinney commented Sep 2, 2021

Yes, that is the purpose of the Guidance section.

  1. We haven't yet, because our guidance for related processes is basically a "hotfix" to OCDS 1.x, and was only recently completed in full. That said, now that we've done it, we can add some normative content to the identifiers page.
  2. "Overfill" is a common problem in standard implementations. The normative statement that is intended to prevent it is "Its usage of this specification's terms must be consistent with the semantics of those terms." (ref) That statement means that you shouldn't put an award value as the contract value when there is no contract yet, for example. We can perhaps expand the point into a longer section about avoiding overfill – but then that's what the Guidance is doing.
  3. Good catch. We should update the field description.
  4. I think this is the work of Update all stage object descriptions and release tags #1385

@JachymHercher
Copy link
Contributor Author

JachymHercher commented Sep 21, 2021

  1. & 3. - ok.
  2. I'm not 100% sure I get this, maybe lets come back to it after Guidance on awards and contracts: when to fill in one and/or the other #1400.

'

  1. Ok, done in ed37c4e.

@jpmckinney jpmckinney added Focus - UX Making information easier to find and interpret and removed Focus - Documentation Includes corrections, clarifications, new guidance, and UI/UX issues labels Nov 22, 2021
@JachymHercher
Copy link
Contributor Author

JachymHercher commented May 17, 2022

  1. Do we set somewhere in Reference that for multistage processes you need multiple ocids? It's not in https://standard.open-contracting.org/latest/en/schema/identifiers/#contracting-process-identifier-ocid, just in https://standard.open-contracting.org/latest/en/guidance/map/related_processes/.

On second thought, I don't think we need to. The desecription of the schema contains "In multiple stage procedures (e.g. framework agreements with reopening of competition), each round of competition is treated as a separate contracting process." and the description of an ocid includes "Alternatively, this identifier can refer to a planning process or a single stage of a multiple stage procedure." The rules on publication conformance (esp. 2) then seem sufficient to create the obligation that multiple-stage procedures have multiple ocids.

  1. Same as above, we don't need more.

  2. Created the PR (main change + a few details since I was changing it already):
    i) Main change: "This can be used to provide an internally used identifier for this organization in addition to the primary legal entity identifier." to "This field can also be used to provide an identifier for an organizational unit (for example, an agency branch or a division)." (I hope "internally used identifier" doesn't mean something else, but I'm assuming not and the expression does not appear in https://standard.open-contracting.org/latest/en/guidance/map/organization_identifiers/ nor https://standard.open-contracting.org/latest/en/guidance/map/organizational_units/.)
    ii) "additional / supplemental identifiers" --> "additional identifiers" (unnecessary synonyms)
    iii) "for the organization or participant" --> "for the organization" (everything is an organization by now)

@JachymHercher JachymHercher added Schema Relating to other changes in the JSON Schema (renamed fields, schema properties, etc.) quick Ready for PR labels May 17, 2022
@jpmckinney
Copy link
Member

jpmckinney commented May 17, 2022

I hope "internally used identifier" doesn't mean something else

The idea was that a publisher might have some way to identify the organization that is not otherwise published elsewhere. For example, the e-GP system might assign database IDs to suppliers, and these IDs don't reconcile with any other system.

That said, we never suggest that these fields are only for reconcilable IDs, so the sentence is unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus - UX Making information easier to find and interpret quick Ready for PR Schema Relating to other changes in the JSON Schema (renamed fields, schema properties, etc.)
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants