Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: header ordering #44

Open
yshalenyk opened this issue Apr 29, 2021 · 3 comments
Open

bug: header ordering #44

yshalenyk opened this issue Apr 29, 2021 · 3 comments
Assignees
@yshalenyk
Labels
bug Something isn't working
Milestone
Priority

Comments

@yshalenyk
Copy link
Contributor

yshalenyk commented Apr 29, 2021 •
edited
Loading

Arrays headers inserted into table in reverse order.
image
@yshalenyk
Copy link
Contributor Author

yshalenyk commented Apr 29, 2021 •
edited
Loading

Also, we may try to use natsort to sort headers at the end on analysis instead keeping order from schema, but it might break expected order of fields (like id, then title, then description).

@jpmckinney
Copy link
Member

See open-contracting/spoonbill-web#145

@sorenabell sorenabell added this to the Production ready 1.0 milestone Apr 29, 2021
@jpmckinney
Copy link
Member

When doing #105, I edited the ocds-sample-data.json file to have a small number of additionalIdentifiers. When I flattened the data, the two entries from the child table had extra columns in between:

  • /parties/additionalIdentifiers/0/scheme
  • /parties/additionalIdentifiers/0/id
  • /parties/additionalIdentifiers/0/legalName
  • /parties/identifier/scheme
  • /parties/identifier/id
  • /parties/identifier/legalName
  • /parties/test
  • /parties/additionalIdentifiers/1/scheme
  • /parties/additionalIdentifiers/1/id
  • /parties/additionalIdentifiers/1/legalName

@yshalenyk yshalenyk added the bug Something isn't working label Jun 4, 2021
@jpmckinney jpmckinney modified the milestones: 2.0, Priority Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yshalenyk yshalenyk

Labels
bug Something isn't working
Projects
None yet
Milestone
Priority
Development

No branches or pull requests
3 participants
@jpmckinney @sorenabell @yshalenyk