-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename CLI options #111
Comments
@jpmckinney I like the suggested changes a lot. The only suggestion I have is that maybe instead of |
I agree with @sabahfromlondon, and another option instead of initial tables is "parent" tables, which makes sense as we are using "child-tables" later. |
I'm happy with |
@sorenabell This is the sort of small change that I am happy to commit on my own, so that Quinta can focus on the more challenging and time-consuming changes. For this kind of change, do you prefer that I assign the PR for review by Quinta, or just merge it myself? |
@jpmckinney please assign PR review for @yshalenyk nevertheless, just for us to be in the loop. |
Some option names could perhaps be improved: https://open-contracting.github.io/spoonbill/cli.html
@sabahfromlondon @yolile What do you think of?
--threshold NUM
->--split-at NUM
, which communicates what action happens at the threshold--selection TABLE,TABLE
->--only-initial-tables TABLE,TABLE
, which clarifies that this is only for initial tables (described in the docs as the top-level planning, tenders, awards, contracts tables), not child tables or columns--exclude TABLE,TABLE
->--exclude-child-tables TABLE,TABLE
, which clarifies that this is only for child tables, not initial tables or columnsI think all other option names are clear (most options are for columns, so I think okay to not have a
-columns
suffix).The text was updated successfully, but these errors were encountered: