Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review console messages in Vue tests #428

Open
jpmckinney opened this issue Apr 7, 2022 · 0 comments
Open

Review console messages in Vue tests #428

jpmckinney opened this issue Apr 7, 2022 · 0 comments
Labels

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Apr 7, 2022

They are currently the same as in 55d60df (Quinta's last commit).

Error-level

  • "[Vue warn]: Error in created hook (Promise/async): "TypeError: Cannot read properties of null (reading 'tables')"" and "TypeError: Cannot read properties of null (reading 'tables') at VueComponent.created (spoonbill-web/frontend/src/views/CustomizeTables.vue:74:27)" in unit/views/CustomizeTables.spec.js

Commenting out store.dispatch = jest.fn(); in the "gets selections once created" test prevents the error message, but then the expect(router.push).toBeCalledTimes(1); expectation fails.

  • 2x "Event { isTrusted: [Getter] }" in unit/views/Download.spec.js

The three tests in Download.spec.js that log error messages are the only ones to interact with the component's subscribeOnChanges, scheduleFlattenGeneration (which calls subscribeOnChanges), and generateFile (which calls scheduleFlattenGeneration). The subscribeOnChanges function might be the cause; commenting out its setupConnection prevents the error messages, but then the test fails.

Warning-level

  • 3x "[Vuetify] Unable to locate target [data-app]" across unit/components/App/AppConfirmDialog.spec.js and unit/components/CustomizeTables/CustomizeDialog.spec.js

These warnings might be because the two components being tested are dialogs?

@jpmckinney jpmckinney changed the title Review warnings in Vue tests Review console messages in Vue tests Apr 7, 2022
jpmckinney added a commit that referenced this issue Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant