Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation of phrases with links #270

Open
yolile opened this issue Jun 15, 2021 · 4 comments
Open

Translation of phrases with links #270

yolile opened this issue Jun 15, 2021 · 4 comments
Labels

Comments

@yolile
Copy link
Member

yolile commented Jun 15, 2021

Currently, all the phrases with links eg "Data Review Tool" are translated as separated strings in transifex. We should consider a way to have them in the same paragraph where they are mentioned, instead of in separated strings. E.g. in

<translate>
The JSON data you upload should be in OCDS 1.1 or 1.0, otherwise it may not be possible to
flatten. If you are uncertain whether your data complies with OCDS, use the
</translate>
<translate
tag="a"
class="text-link"
target="_blank"
rel="noopener"
href="https://standard.open-contracting.org/review/"
>
Data Review Tool
</translate>
<translate> to check first</translate>.

we should consider using the same translate tag for the complete paragraph

@sorenabell
Copy link
Contributor

The issue was fixed. Please check.

@yolile
Copy link
Member Author

yolile commented Oct 4, 2021

Hmm I still see the strings as separate strings in transifex and in the code
image

<v-expansion-panel-content>
<translate>
The JSON data you upload should be in OCDS version 1.1 or 1.0, otherwise it may not be
</translate>
<translate> possible to flatten.</translate>
<br />
<translate> If you are uncertain whether your data complies with OCDS, use the </translate>
<span>
<a href="https://standard.open-contracting.org/review/" target="_blank">
<translate> Data Review Tool </translate>
</a>
</span>
<translate> to check first. </translate>
</v-expansion-panel-content>

@yolile yolile reopened this Oct 4, 2021
@sorenabell
Copy link
Contributor

But the text on UI is translated?

@jpmckinney
Copy link
Member

I think we can leave this as a low-priority cleanup task, which OCP can do at some time.

@jpmckinney jpmckinney self-assigned this Oct 4, 2021
@jpmckinney jpmckinney added i18n and removed chore labels Dec 15, 2021
@jpmckinney jpmckinney removed their assignment May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants