Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a correctly formatted value when reporting invalid values #141

Closed
jpmckinney opened this issue Jan 5, 2021 · 1 comment
Closed
Labels
check results Relating to how specific checks are reported

Comments

@jpmckinney
Copy link
Member

For example:

  • Showing what a valid date looks like when reporting an invalid date
  • Displaying the value surrounded by quotes, when reporting a non-string

Split from document linked in #101

@jpmckinney jpmckinney added the check results Relating to how specific checks are reported label Jan 5, 2021
@jpmckinney
Copy link
Member Author

lib-cove-ocds has "Incorrect date format. Dates should use the form YYYY-MM-DDT00:00:00Z. Learn more about dates in OCDS."

lib-cove-web has:

  • {}<code>{}</code> is not a string. Check that the value {} has quotes at the start and end. Escape any quotes in the value with <code>\</code>
  • {}<code>{}</code> is not a integer. Check that the value {} doesn’t contain decimal points or any characters other than 0-9. Integer values should not be in quotes.
  • {}<code>{}</code> is not a number. Check that the value {} doesn’t contain any characters other than 0-9 and dot (<code>.</code>). Number values should not be in quotes.

So, this issue is already done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check results Relating to how specific checks are reported
Projects
None yet
Development

No branches or pull requests

1 participant