CalculateNegativeVolumeIndex, CalculatePositiveVolumeIndex alwas return array of zeros

[siesta-trading]

OoplesFinance.StockIndicators/src/Calculations/Volume.cs

Line 267 in ddc4c11

double nvi = currentVolume >= prevVolume ? prevNvi : prevNvi + (prevNvi * pctChg);

The problem is here:

double prevNvi = nviList.LastOrDefault();
double nvi = currentVolume >= prevVolume ? prevNvi : prevNvi + (prevNvi * pctChg);
nviList.AddRounded(nvi);

because prevNvi is initialized as 0 and therefore nvi also assigned 0 and on next iteration prevNvi again assigned 0 and so on.
solution: prevNvi should never be assigned 0.

[ooples]

@siesta-trading I just did a commit that fixes this issue in both calculations so can you please get the latest version and test it to make sure it is working now?

[siesta-trading]

I was looking at the fix you have implemented.
I think there is still a possibility that nvi can be set to 0 and therefore the problem persists.
For example:

Iteration 1:
i=0
prevNvi=1000
nvi=1000

iteration 2:
i=1
prevNvi=1000
pctChg=-1
currentVolume < prevVolume
nvi=0(!!!)

back to the original issue.
I would recommend the solution to be something like:
if (prevNvi == 0)
prevNvi=0.0001;

[ooples]

@siesta-trading I fixed the issue you found and moved the initial value to the parameter so you can override with your own custom value as well

[ooples]

@siesta-trading Please confirm that your issue was fixed with the most recent version and close this issue if it is resolved