Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capabilities API labeled deprecated but Capability Controllers aren't yet on m #400

Closed
sisyphusSmiling opened this issue Jul 20, 2023 · 3 comments · Fixed by onflow/cadence#2673

Comments

@sisyphusSmiling
Copy link

Problem

The Capabilities API is planned to be deprecated in favor of Capability Controllers (CapCons), but CapCons are not yet live on Mainnet and VS Code extension notifies devs that the existing Capability API is deprecated.

A dev following the instructions presented would find a lack of documentation on the suggested API and be frustrated to find out that the API they implemented isn't yet supported on Mainnet.

Steps to Reproduce

  1. Run emulator
  2. Attempt to retrieve a Capability using the existing API
Screenshot 2023-07-20 at 2 16 36 PM

Acceptance Criteria

The notice is removed until CapCons are live on Mainnet at which point the plan is to support a transition period between APIs and the deprecation notice would be appropriate.

Context

Originally thought CapCons were a blocker for Mainnet deployment, but realized the feature is not yet supported.

@m-Peter
Copy link

m-Peter commented Jul 20, 2023

I will have a shot at this 🙏

@m-Peter
Copy link

m-Peter commented Jul 21, 2023

There are some more functions that have the same issue, that is described above. E.g:

capability-api-deprecations

@m-Peter
Copy link

m-Peter commented Jul 21, 2023

Opened a PR to address this: onflow/cadence#2673

@turbolent turbolent removed the bug Something isn't working label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants