Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules to depend on storage layers instead of database operation functions #6146

Closed
zhangchiqing opened this issue Jun 24, 2024 · 1 comment
Labels
Stale Label used when marking an issue stale.

Comments

@zhangchiqing
Copy link
Member

zhangchiqing commented Jun 24, 2024

Context

We have many places read and write data with database operation functions directly. This direct dependencies on the badger-based operation functions make it hard to implement the following features, since the data might store in different database:

  1. badger -> pebble migration
  2. implement pruning for regisiter DB or chunk data pack DB.

Proposed Solution

It's better for the modules to depend on the storage interfaces instead of database-specific operation functions, so that by using different storage implementation, it knows how to do the same operation for different databases.

TODO

Update modules that uses database operation functions to use storage interface methods.

cc @peterargue

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Label used when marking an issue stale. label Sep 24, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Label used when marking an issue stale.
Projects
None yet
Development

No branches or pull requests

1 participant