Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meter computation in new stdlib functions #2879

Closed
6 of 7 tasks
turbolent opened this issue Oct 18, 2023 · 1 comment · Fixed by #3172
Closed
6 of 7 tasks

Meter computation in new stdlib functions #2879

turbolent opened this issue Oct 18, 2023 · 1 comment · Fixed by #3172
Assignees

Comments

@turbolent
Copy link
Member

turbolent commented Oct 18, 2023

Issue to be solved

Some of the new stdlib functions perform non-constant operations, which require computation metering:

Suggested Solution

Implementations should call ReportComputation, potentially with a new (?) common.ComputationKind.

Metering might also require "inlining" existing calls to the Go stdlib, so that each iteration of an operation can be metered up-front.

@turbolent
Copy link
Member Author

turbolent commented Oct 18, 2023

@SupunS can you please have a look at this with @darkdrag00nv2 this/next week? The PRs that got merged into master have a high priority, as they need to get metered before the spork, the ones for Stable Cadence have a lower priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants