Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom maprange linter to GitHub Actions from Cadence #344

Open
fxamacker opened this issue Sep 22, 2023 · 0 comments
Open

Add custom maprange linter to GitHub Actions from Cadence #344

fxamacker opened this issue Sep 22, 2023 · 0 comments
Labels
CI CI and GitHub Actions Workflows

Comments

@fxamacker
Copy link
Member

fxamacker commented Sep 22, 2023

Issue To Be Solved

GitHub Actions should add a custom linter to check map ranges.

Suggested Solution

Great suggestion by @turbolent

In Cadence we're using a custom linter to reject such cases (https://github.com/onflow/cadence/tree/master/tools/maprange), we might want to also use it in the atree repo?

Given that GitHub workflows can consume a lot of time, one approach is to download precompiled binaries of the custom linter(s) from Cadence repo (same way golangci-lint binaries can be downloaded from their repo).

E.g. https://github.com/golangci/golangci-lint/releases/tag/v1.53.3

@fxamacker fxamacker added the CI CI and GitHub Actions Workflows label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI and GitHub Actions Workflows
Projects
None yet
Development

No branches or pull requests

1 participant